[PATCH] D92020: [AllocaInst] Update `getAllocationSizeInBits` to return `TypeSize`.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:589
   sort(FrameData.Allocas, [&](const auto &Iter1, const auto &Iter2) {
-    return GetAllocaSize(Iter1) > GetAllocaSize(Iter2);
+    return TypeSize::isKnownGT(GetAllocaSize(Iter1), GetAllocaSize(Iter2));
   });
----------------
This should maintain the original `operator>` and instead `GetAllocaSize` should return `RetSize->getFixedSize()`.


================
Comment at: llvm/unittests/IR/InstructionsTest.cpp:502
 
-
 TEST(InstructionsTest, isEliminableCastPair) {
----------------
nit: unnecessary change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92020/new/

https://reviews.llvm.org/D92020