[PATCH] D90418: [debuginfo] Vectorizing a loop doesn't terminate all vectorized variable locations

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/DebugInfo/pr39018.ll:1
+;; PR39018
+;; Ensure that the loop vectorizer updates the debuginfo
----------------
the test is for functionality in LoopVectorize. Should we also have a test in test/Transforms/LoopVectorize? I think we have other debug related tests there.


================
Comment at: llvm/test/DebugInfo/pr39018.ll:44
+; Function Attrs: nounwind readnone uwtable
+define dso_local i32 @main() local_unnamed_addr !dbg !7 {
+entry:
----------------
The test seems much more verbose than necessary to test the patch. For example, instead of the memset & allocas, you could just pass noalias pointers. Also, are 2 loops needed? From the patch, I'd assume no.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90418/new/

https://reviews.llvm.org/D90418