[PATCH] D91500: [VPlan] Turn VPReplicateRecipe into a VPValue.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:134
 const VPValue *VPRecipeBase::toVPValue() const {
   if (auto *V = dyn_cast<VPInstruction>(this))
     return V;
----------------
reames wrote:
> Out of scope for this patch, but these three really look like evidence of missing isa infrastructure for the types in question.
Agreed. Currently the problem is that `VPRecipeBase` does not inherit from VPValue or VPUser. The `toVPValue` helpers are there to avoid casting between a base class and a different type that's not a subtype. Both of those helpers are only used during the transition (until all recipes have been updated) and should go away soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91500/new/

https://reviews.llvm.org/D91500