[PATCH] D92098: [obj2yaml] - Dump the `EShNum` key in some cases.

Thu Nov 26 05:30:11 PST 2020

grimar updated this revision to Diff 307843.
grimar retitled this revision from "[obj2yaml] - Don't crash when dumping an object with no sections." to "[obj2yaml] - Dump the `EShNum` key in some cases.".
grimar edited the summary of this revision.
grimar added a comment.
This revision is now accepted and ready to land.

In D92098#2418299 <https://reviews.llvm.org/D92098#2418299>, @grimar wrote:

> I am experimenting with the patch which preserves the `EShNum` key when e_shnum == 0. It is usefull for the normal scenario when
> the number of sections is greater than or equal to the `SHN_LORESERVE `.
>
> I'll rebase this patch later. I think that after we start emitting the `EShNum = 0`, this patch will produce an equivalent output for the input given.

It turns out this is impossible to prepare a different patch because of this crash.
So updating this one with the new functionality.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92098/new/

https://reviews.llvm.org/D92098

Files:
  llvm/test/tools/obj2yaml/ELF/eshnum.yaml
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92098.307843.patch
Type: text/x-patch
Size: 4184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201126/445fcc47/attachment.bin>