[PATCH] D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 04:32:32 PST 2020

sdesmalen added a comment.

Hi @kmclaughlin, we just discussed this offline, just sharing my thoughts here as well.

The code-changes seem fine, but I think the patch series is in the wrong order. i.e. D91084 <https://reviews.llvm.org/D91084> is an optimization for D91092 <https://reviews.llvm.org/D91092>. The better order I think would probably be to:

1. Have https://reviews.llvm.org/D91092 as a standalone patch (you'll need to update the test and remove the reference to MGT->getExtensionType()
2. Add the ExtensionType flag to MGATHER (re-adding the reference to MGT->getExtensionType() in LowerMGATHER, but the tests are probably unchanged).
3. Add the DAGCombines to merge zext/sext into the mgather itself (which then requires updating the tests)



More information about the llvm-commits mailing list