[PATCH] D91595: [Debugify] Support checking Machine IR debug info

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:126
+    cl::desc(
+        "Debugify MIR before and Check + Strip debug after "
+        "each pass except those known to be unsafe when debug info is present"),
----------------
djtodoro wrote:
> xiangzhangllvm wrote:
> > djtodoro wrote:
> > > The description should be more precise.
> > The name and description of "debugify-and-check-strip-all-safe" refer to upper "debugify-and-strip-all-safe", Maybe It is a little different for our non-English speaking people to name or descript well. Do you have good suggestion of its name ?
> > How about I refine the description to "Debugify MIR before each pass except those known to be unsafe when debug info is present, then run mir-check-debugify for them, and finally strip the debug info with mir-strip-debug" ?
> >The name and description of "debugify-and-check-strip-all-safe" refer to upper "debugify-and-strip-all-safe"
> I think "debugify-check-and-strip-all-safe" would be more appropriate, wdyt?
> 
> (`DebugifyAndCheckStripAll` should be `DebugifyCheckAndStripAll`)
> 
> >How about I refine the description to "Debugify MIR before each pass except those known to be unsafe when debug info is present, then run mir-check-debugify for them, and finally strip the debug info with mir-strip-debug" ?
> Hmm... we are checking/stripping after each pass right?
> 
> "Debugify MIR before, by checking and stripping the debug info after, each pass except those known to be unsafe when debug info is present" ?
> 
>  think "debugify-check-and-strip-all-safe" would be more appropriate, wdyt?
Looks good!
> Hmm... we are checking/stripping after each pass right?
Yes, same with "debugify-and-strip-all-safe".
> "Debugify MIR before, by checking and stripping the debug info after, each pass except those known to be unsafe when debug info is present"
That's better, thank you!!




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91595/new/

https://reviews.llvm.org/D91595