[PATCH] D91339: [X86] Include %rip for 32-bit RIP-relative relocs for x32

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 01:24:44 PST 2020


hvdijk added a comment.

In D91339#2417918 <https://reviews.llvm.org/D91339#2417918>, @dstenb wrote:

> What is the status of the expensive check failure? It has been present for five days now.

The fixes are ready but have not been approved yet. They are D91924 <https://reviews.llvm.org/D91924> and D91933 <https://reviews.llvm.org/D91933>.

> Should we revert this patch until that is resolved?

The test could be disabled for x32 until those other fixes go in though, if wanted. There should be no need to revert the functional part of this patch: the breakage is unrelated to it, this is merely something that was previously not covered by any tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91339/new/

https://reviews.llvm.org/D91339



More information about the llvm-commits mailing list