[PATCH] D92086: Generalized PatternMatch & InstSimplify

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/include/llvm/IR/Traits/Traits.h:182
+  return isa<const RegularCmpInst>(V) ||
+         cast<typename Trait::Intrinsic>->getFunctionalOpcode() == OPC;
+}
----------------
I'm confused: How does this work? Shouldn't there be an `isa<typename Trait::Intrinsic>(V)` check? Actually, how does this even compile? It seems like a (V) is missing on the cast.


================
Comment at: llvm/include/llvm/IR/Traits/Traits.h:243
+
+// TODO Implement other extended types.
+
----------------
Which ones do you have in mind?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92086/new/

https://reviews.llvm.org/D92086