[PATCH] D92073: [CodeGen] Add text section prefix for COFF object file

[TaoPan via Phabricator via llvm-commits]

TaoPan added inline comments.


================
Comment at: llvm/test/CodeGen/X86/text-section-prefix.ll:1
+; RUN: llc -function-sections < %s
+
----------------
pengfei wrote:
> TaoPan wrote:
> > rnk wrote:
> > > TaoPan wrote:
> > > > pengfei wrote:
> > > > > What's your checking here?
> > > > I added some description in Summary.
> > > > 
> > > > The line of output
> > > >    .section     .text,xxx
> > > > will be changed to
> > > >    .section     .text**$hot**,xxx
> > > > or
> > > >    .section     .text**$unlikely**,xxx
> > > > with this patch on Windows.
> > > Please run this test in a few configurations. You can add two RUN lines like:
> > > ```
> > > ; RUN: llc -mtriple x86_64-linux-gnu %s -o - | FileCheck %s --check-prefix=ELF
> > > ; RUN: llc -mtriple x86_64-linux-gnu -unique-section-names=0 %s -o - | FileCheck %s --check-prefix=ELF-NOUNIQ
> > > ; RUN: llc -mtriple x86_64-windows-msvc %s -o - | FileCheck %s --check-prefix=MSVC
> > > ; RUN: llc -mtriple x86_64-windows-msvc %s -o - | FileCheck %s --check-prefix=MINGW
> > > ```
> > > 
> > > Add check lines for the section directives.
> > Thanks for your nice guidance!
> > I'll try your RUN lines.
> I see. Then you just need to add RUNs as Reid suggested and checks like what in section.ll
ok, I'll add RUNs and checks as Reid and MaskRay suggested, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92073/new/

https://reviews.llvm.org/D92073