[PATCH] D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 17:28:31 PST 2020


lhames added a comment.

In D91935#2415346 <https://reviews.llvm.org/D91935#2415346>, @tstellar wrote:

> Thanks for the explanation.  Doing a git clone as part of the build is usually discouraged, though I see Lang approved the original patch.  Is this code disabled by default?

I approved under the understanding that this was off by default, but I'm definitely not a build system expert -- If you feel this should be done differently then that seems worth discussing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91935/new/

https://reviews.llvm.org/D91935



More information about the llvm-commits mailing list