[PATCH] D91500: [VPlan] Turn VPReplicateRecipe into a VPValue.

Wed Nov 25 16:50:54 PST 2020

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

Had a long conversation w/Florian today; he was nice enough to give a lot of context and general direction which helped me understand where this is going.  It also helps that e0c479cd <https://reviews.llvm.org/rGe0c479cd0e03279784925ece209ff53bdbb86cf8>, and 00a6601 <https://reviews.llvm.org/rG00a66011366c7b037d6680e6015524a41b761c34> landed recently showing alignment with the direction sketched here.

Given that, LGTM

================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:134
 const VPValue *VPRecipeBase::toVPValue() const {
   if (auto *V = dyn_cast<VPInstruction>(this))
     return V;
----------------
Out of scope for this patch, but these three really look like evidence of missing isa infrastructure for the types in question.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91500/new/

https://reviews.llvm.org/D91500