[PATCH] D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 14:26:25 PST 2020


dstenb added a comment.

In D91153#2415351 <https://reviews.llvm.org/D91153#2415351>, @mkazantsev wrote:

> Please move the test out of MIPS-specific into general test directory if it's possible. Otherwise, LGTM.

Thanks for the review! The output for the MIPS test case differed quite a bit depending on which target it was run on, so that would have complicated the FileChecks. Due to that, I used the X86 reproducer provided by @TaWeiTu instead, and moved that to the general test directory.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91153/new/

https://reviews.llvm.org/D91153



More information about the llvm-commits mailing list