[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

[Sylvain Audi via Phabricator via llvm-commits]

saudi created this revision.
saudi added reviewers: rnk, thakis, rsmith, AndyG.
saudi added a project: clang.
Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, ormris, hiraditya.
Herald added a project: LLVM.
saudi requested review of this revision.

The test now moves the header files between the pch creation and its use.
This change caused failures under Windows:

- The `-isysroot` path matching was failing when given variations of casing or separators (`/` vs `\`)
- clang `-verify` checks "`// expected-[note/warning/...]@[file]:[line] ...`" would fail when `file` is an absolute path, since the `:` character was interpreted as the delimiter between `[file]` and `[line]`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92136

Files:
  clang/lib/Frontend/VerifyDiagnosticConsumer.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/test/PCH/reloc-windows.c
  clang/test/PCH/reloc.c
  llvm/include/llvm/Support/Path.h
  llvm/lib/Support/Path.cpp
  llvm/unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92136.307707.patch
Type: text/x-patch
Size: 10851 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201125/5fa55dec/attachment.bin>