[PATCH] D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites.

Amy Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 13:31:06 PST 2020

akhuang created this revision.
akhuang added a reviewer: rnk.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
akhuang requested review of this revision.

The existing code handles this correctly and I checked that the code
in NativeInlineSiteSymbol also handles this correctly, but it was
wrong in the NativeFunctionSymbol code.

  rG LLVM Github Monorepo



Index: llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
--- llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
+++ llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
@@ -78,10 +78,7 @@
     case BinaryAnnotationsOpCode::ChangeCodeLengthAndCodeOffset:
       CodeOffset += Annot.U2;
-      if (OffsetInFunc >= CodeOffset)
-        Found = true;
-      CodeOffset += Annot.U1;
-      if (Found && OffsetInFunc < CodeOffset)
+      if (OffsetInFunc >= CodeOffset && OffsetInFunc < CodeOffset + Annot.U1)
         return true;
       Found = false;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92134.307711.patch
Type: text/x-patch
Size: 655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201125/2a4c5ea6/attachment.bin>

More information about the llvm-commits mailing list