[PATCH] D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-labels.ll:32
 
-; CHECK-LABEL:	_Z3bazb:
-; CHECK-LABEL:	.Lfunc_begin0:
-; CHECK-LABEL:	.LBB_END0_0:
-; CHECK-LABEL:	.LBB0_1:
-; CHECK-LABEL:	.LBB_END0_1:
-; CHECK-LABEL:	.LBB0_2:
-; CHECK-LABEL:	.LBB_END0_2:
-; CHECK-LABEL:	.LBB0_3:
-; CHECK-LABEL:	.LBB_END0_3:
-; CHECK-LABEL:	.Lfunc_end0:
-
-; CHECK:	.section	.llvm_bb_addr_map,"o", at llvm_bb_addr_map,.text
-; CHECK-NEXT:	.quad	.Lfunc_begin0
-; CHECK-NEXT:	.byte	4
-; CHECK-NEXT:	.uleb128 .Lfunc_begin0-.Lfunc_begin0
-; CHECK-NEXT:	.uleb128 .LBB_END0_0-.Lfunc_begin0
-; CHECK-NEXT:	.byte	0
-; CHECK-NEXT:	.uleb128 .LBB0_1-.Lfunc_begin0
-; CHECK-NEXT:	.uleb128 .LBB_END0_1-.LBB0_1
-; CHECK-NEXT:	.byte	0
-; CHECK-NEXT:	.uleb128 .LBB0_2-.Lfunc_begin0
-; CHECK-NEXT:	.uleb128 .LBB_END0_2-.LBB0_2
-; CHECK-NEXT:	.byte	1
-; CHECK-NEXT:	.uleb128 .LBB0_3-.Lfunc_begin0
-; CHECK-NEXT:	.uleb128 .LBB_END0_3-.LBB0_3
-; CHECK-NEXT:	.byte	5
+; UNIQ: .section .text._Z3bazb,"ax", at progbits
+; NOUNIQ: .section .text,"ax", at progbits,unique,1
----------------
Append `{{$}}` and try aligning the start of `.section`


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-labels.ll:34
+; NOUNIQ: .section .text,"ax", at progbits,unique,1
+; CHECK-LABEL:  _Z3bazb:
+; CHECK-LABEL:  .Lfunc_begin0:
----------------
What happens with the whitespace change?


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-labels.ll:45
+
+; UNIQ: .section	.llvm_bb_addr_map,"o", at llvm_bb_addr_map,.text._Z3bazb
+;; Verify that with -unique-section-names=false, the unique id of the text section gets assigned to the llvm_bb_addr_map section.
----------------
Append `{{$}}` to show that `,unique` is not used


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92113/new/

https://reviews.llvm.org/D92113