[PATCH] D92088: [AMDGPU][MC] Improved diagnostics message for sym/expr operands

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 10:16:40 PST 2020


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5746
     }
-  } else if (parseExpr(ImmVal)) {
+  } else if (parseExpr(ImmVal, "an hwreg macro")) {
     if (ImmVal < 0 || !isUInt<16>(ImmVal)) {
----------------
"a hwreg macro".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92088/new/

https://reviews.llvm.org/D92088



More information about the llvm-commits mailing list