[PATCH] D91937: [ISel] Port AArch64 SABD and UABD to DAGCombine

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 09:10:05 PST 2020


dmgreen updated this revision to Diff 307632.
dmgreen marked an inline comment as done.
dmgreen added a comment.

Thanks for taking a look.

> What other archs have equivalent instructions?

It was MVE I was hoping to share this with, over in the ARM backend. I don't know if any other backend would find this useful too - it would be great if they did. I find it hard enough to know what ARM instructions do some of the time let along other architectures! I believe the X86 instruction (PSADBW) works quite differently, as it includes a reduction step?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91937/new/

https://reviews.llvm.org/D91937

Files:
  llvm/include/llvm/CodeGen/ISDOpcodes.h
  llvm/include/llvm/Target/TargetSelectionDAG.td
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64InstrInfo.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91937.307632.patch
Type: text/x-patch
Size: 10052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201125/0279e822/attachment.bin>


More information about the llvm-commits mailing list