[PATCH] D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 09:04:21 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/MC/ELF/section-entsize-changed.s:14
+
+bar:
+.section .bar,"ax", at progbits
----------------
Unused(should be deleted)


================
Comment at: llvm/test/MC/ELF/section-entsize-changed.s:28
+foobar:
+.section .foobar,"ax", at progbits; .byte 1
+
----------------
.byte directives are unused (should be deleted)


================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:3
+
+// CHECK: .section        .foo,"aM", at progbits,1
+// CHECK: .section        .bar,"aM", at progbits,4
----------------
`#`


================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:11
+
+.pushsection .foo
+
----------------
No need for multiple `pushsection .foo`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92052/new/

https://reviews.llvm.org/D92052



More information about the llvm-commits mailing list