[PATCH] D91851: [compiler-rt] [emutls] Add ifdefs around msvc specific pragmas

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: compiler-rt/lib/builtins/emutls.c:33
 #pragma warning(push)
 #pragma warning(disable : 4206)
 #endif
----------------
mstorsjo wrote:
> I also noticed that we have a similar case elsewhere already in the same file, which uses `#if defined(_MSC_VER) && !defined(__clang__)`.
Yeah, using `#if defined(_MSC_VER) && !defined(__clang__)` in place of !mingw.


================
Comment at: compiler-rt/lib/builtins/emutls.c:187
 #pragma warning(push)
 #pragma warning(disable : 4100)
+#endif
----------------
mstorsjo wrote:
> I looked up warning 4100, https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4100, which is "unreferenced formal parameter". So I would guess one could silence that also just with a couple `(void)p0; (void)p1; (void)p2;` in the function...
I actually like your idea of the cast better TBH.  That is something that is not specific to MSVC but other compilers can trip over as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91851/new/

https://reviews.llvm.org/D91851