[PATCH] D89740: [ms] [llvm-ml] Implement the statement expansion operator

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 08:31:19 PST 2020


thakis added a comment.

Looks like there's no coverage for expanding statements that aren't the echo special case - - could you add coverage for that too? Other than that, lg!



================
Comment at: llvm/include/llvm/MC/MCAsmMacro.h:147
   std::vector<std::string> Locals;
+  bool Function = false;
 
----------------
IsFunction


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:5517
   unsigned MacroDepth = 0;
+  bool MacroFunction = false;
   // Lex the macro definition.
----------------
IsMacroFunction


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89740/new/

https://reviews.llvm.org/D89740



More information about the llvm-commits mailing list