[PATCH] D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 06:30:25 PST 2020


jhenderson added a comment.

FWIW, I'm with @grimar in the sense that I think this is poor and unnecessary behaviour provided for by the psABI. Why emit the relocation type in this context, when the primary purpose of this relocation type is to enable relaxations? Why not emit the generic GOTPCREL relocation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91993/new/

https://reviews.llvm.org/D91993



More information about the llvm-commits mailing list