[PATCH] D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

This seems to break compiler-rt tests on darwin:

  Testing:  0.. 10.. 
   FAIL: Builtins-x86_64-darwin :: divdf3_test.c (43 of 208)
   ******************** TEST 'Builtins-x86_64-darwin :: divdf3_test.c' FAILED ********************
   Script:
   --
   : 'RUN: at line 1';       /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/./bin/clang   -gline-tables-only  -arch x86_64 -stdlib=libc++ -mmacosx-version-min=10.10 -isysroot /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -DCOMPILER_RT_HAS_FLOAT16  -fno-builtin -I /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/builtins -nodefaultlibs /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/divdf3_test.c /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/./lib/clang/12.0.0/lib/darwin/libclang_rt.osx.a  -lSystem -o /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/projects/compiler-rt/test/builtins/Unit/X86_64DarwinConfig/Output/divdf3_test.c.tmp &&  /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/projects/compiler-rt/test/builtins/Unit/X86_64DarwinConfig/Output/divdf3_test.c.tmp
   --
   Exit Code: 1
   
   Command Output (stderr):
   --
   In file included from /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/divdf3_test.c:7:
   /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:16:15: error: _Float16 is not supported on this target
   static inline TYPE_FP16 fromRep16(uint16_t x)
                 ^
   /opt/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/test/builtins/Unit/fp_test.h:7:19: note: expanded from macro 'TYPE_FP16'
   #define TYPE_FP16 _Float16
                     ^
  [...]
   Failed Tests (6):
     Builtins-x86_64-darwin :: divdf3_test.c
     Builtins-x86_64-darwin :: divsf3_test.c
     Builtins-x86_64-darwin :: extendhfsf2_test.c
     Builtins-x86_64-darwin :: truncdfhf2_test.c
     Builtins-x86_64-darwin :: truncdfsf2_test.c
     Builtins-x86_64-darwin :: truncsfhf2_test.c
   
   
   Testing Time: 11.16s
     Unsupported      :  62
     Passed           : 139
     Expectedly Failed:   1
     Failed           :   6
   

Full log https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863130845589077872/+/steps/package_clang/0/stdout?format=raw

Upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1152762

Please take a look, and revert for now if it takes a while to fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91732/new/

https://reviews.llvm.org/D91732