[PATCH] D91043: [DebugInfo] Fix convert-loclist.ll
Luís Marques via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 25 04:08:21 PST 2020
luismarques added a comment.
In D91043#2415178 <https://reviews.llvm.org/D91043#2415178>, @dblaikie wrote:
> (3) is part of it, but not quite. All these test "REQUIRES" x86 (the DebugInfo/X86 directory has this as a general requirement)
I'm not disagreeing with your overall point, but the directory has the check `if not 'X86' in config.root.targets`, so that checks for target support. When I mentioned the `REQUIRES` I mean checking for an actual x86 host, not `REQUIRES: x86-registered-target`.
> So that explains some benign llc_dwarf usage. Though not all of it - I found 7 tests without -mtriple or a target triple in the IR:
>
> llvm/test/DebugInfo/X86/convert-debugloc.ll
> llvm/test/DebugInfo/X86/convert-inlined.ll
> llvm/test/DebugInfo/X86/convert-linked.ll
> llvm/test/DebugInfo/X86/convert-loclist.ll
> llvm/test/DebugInfo/X86/dbg-byval-parameter.ll
> llvm/test/DebugInfo/X86/debug-macro.ll
> llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll
Thanks! I noticed that `abstract_origin.ll`, updated in your commit, does have an IR target triple, and your command-line override only matched it loosely. Perhaps that test wasn't updated quite the way it should have been? (e.g. keep the `%llc_dwarf`, remove the IR triple, etc.).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91043/new/
https://reviews.llvm.org/D91043
More information about the llvm-commits
mailing list