[PATCH] D88447: [VPlan] Switch VPWidenRecipe to be a VPValue
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 25 03:11:44 PST 2020
fhahn added a comment.
In D88447#2415543 <https://reviews.llvm.org/D88447#2415543>, @dmgreen wrote:
> OK. Thanks for the review. Lets give this a go and see if anything complains. I've managed to run a sanitized build successfully at least, but let me know if anything else doesn't work.
Thanks! I rebased my set of patches on top of it an everything seems to work out fine. One thing I forgot to mention was adding a `VPReductionSC` case to `VPUser::classof`, which I did in rGad5b83ddcf45 <https://reviews.llvm.org/rGad5b83ddcf45372f61b9602038006a2ec58dab4a>, together with unifying the VPValue ID names (some were using VPVBla and other VPBla)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88447/new/
https://reviews.llvm.org/D88447
More information about the llvm-commits
mailing list