[PATCH] D91525: [LoopLoadElim] Make sure all loops are in simplify form. PR48150

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 25 01:46:06 PST 2020


mkazantsev added a comment.

In D91525#2412162 <https://reviews.llvm.org/D91525#2412162>, @aeubanks wrote:

> I'm not super familiar with this, do you know why this only affects the new PM? (the code looks fine, I'd just like to understand what's going on better)



  void getAnalysisUsage(AnalysisUsage &AU) const override {
    AU.addRequiredID(LoopSimplifyID);

Because of this, all loops in old PM are simplified before the opt starts.



================
Comment at: llvm/test/Transforms/LoopLoadElim/pr-48150.ll:2
 ; RUN: opt -passes=loop-load-elim -S < %s | FileCheck %s
 ; REQUIRES: asserts
 
----------------
aeubanks wrote:
> is this still necessary?
Nope.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91525/new/

https://reviews.llvm.org/D91525



More information about the llvm-commits mailing list