[PATCH] D91711: SCEV add function to see if SCEVUnknown is null

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 20:21:33 PST 2020


mkazantsev added a comment.

The idea of having SCEV pointing to deleted instructions scares me. Imagine what if we had SCEVAddRecs referencing the loops we've already deleted.  There is a vast field for nasty bugs caused by UB and memory corruption. I'd rather expect that we fail some assertion if we try to optimize with SCEV in that state.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91711/new/

https://reviews.llvm.org/D91711



More information about the llvm-commits mailing list