[PATCH] D68720: Support -fstack-clash-protection for x86

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 17:34:17 PST 2020


emaste added inline comments.
Herald added subscribers: dexonsmith, pengfei.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010
+
+  if (!EffectiveTriple.isOSLinux())
+    return;
+
----------------
Is there anything OS-dependent here?

I plan to add `EffectiveTriple.isOSFreeBSD()` to FreeBSD-s in-tree Clang
https://reviews.freebsd.org/D27366
and intend to upstream the change (with a test), but should we just remove the OS test completely?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68720/new/

https://reviews.llvm.org/D68720



More information about the llvm-commits mailing list