[PATCH] D92049: [CodeView] Avoid emitting empty debug globals subsection.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 16:08:27 PST 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3140
     else
-      continue;
+      assert(false && "cannot emit a constant without a value");
 
----------------
LLVM likes to use llvm_unreachable instead for this kind of case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92049/new/

https://reviews.llvm.org/D92049



More information about the llvm-commits mailing list