[PATCH] D92060: [lld] Add --no-lto-whole-program-visibility

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

This looks good.



================
Comment at: lld/test/ELF/lto/devirt_vcall_vis_public.ll:34
 ; RUN: llvm-dis %t2.o.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-NODEVIRT-IR
+; Try again with explicit --no-lto-whole-program-visibility.
+; RUN: ld.lld %t2.o -o %t3 -save-temps --no-lto-whole-program-visibility \
----------------
Could you also add some comments that the existing --export-dynamic is to retain the symbols?


================
Comment at: lld/test/ELF/lto/devirt_vcall_vis_public.ll:39
+; Ensure --no-lto-whole-program-visibility overrides explicit --lto-whole-program-visibility.
+; RUN: ld.lld %t2.o -o %t3 -save-temps --lto-whole-program-visibility --no-lto-whole-program-visibility \
+; RUN: 	 -mllvm -pass-remarks=. --export-dynamic 2>&1 | FileCheck %s --implicit-check-not single-impl --allow-empty
----------------
A `--lto-whole-program-visibility --no-lto-whole-program-visibility` RUN list is sufficient, no need for the previous RUN line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92060/new/

https://reviews.llvm.org/D92060