[PATCH] D90488: [flang][openacc] Lower init and shutdown directive
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 24 14:57:55 PST 2020
clementval added a comment.
In D90488#2414920 <https://reviews.llvm.org/D90488#2414920>, @mehdi_amini wrote:
> If this can't be tested / is dead code, I'm not super comfortable having this in-tree. What is the plan for fir-dev development to move upstream, I'm still quite puzzled and don't understand why the development does not happen in tree, I think I asked on the mailing list but never got an answer.
There was discussion on the last few calls to move it upstream every soon. An RFC should have been sent to coordinate the upstreaming of the fir-dev patch. Looks like it hasn't moved yet. @kiranchandramohan @SouraVX @schweitz @sscalpone Do you know if there is any progress with the upstreaming process?
@mehdi_amini I'm fine with removing this code can be upstream again later if you prefer. Same with all the code in `flang/lib/Lower/OpenACC.cpp`.
The tests have been created and they are ready to be upstreamed as soon as I can (https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev/flang/test/Lower/OpenACC)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits