[PATCH] D90171: [SVE] Fix TypeSize warning in RuntimePointerChecking::insert
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 24 10:32:44 PST 2020
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM with the comment adjustment, thanks!
================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:3544
+const SCEV *ScalarEvolution::getStoreSizeOfExpr(Type *IntTy, Type *StoreTy) {
+ // We can bypass creating a target-independent
+ // constant expression and then folding it back into a ConstantInt.
----------------
if you are touching the comment lines, could. you also re-flow the comment?
Also, this comment should be moved to the `getConstant` call, right? Because for scalable vectors we create a constant expression.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90171/new/
https://reviews.llvm.org/D90171
More information about the llvm-commits
mailing list