[PATCH] D91174: [Analysis] Introduce a new InstructionCost class

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 09:00:07 PST 2020


ctetreau added a comment.

I marked it "needs changes" to rescind my acceptance due to Sander's issue. However, I'm fine with this (aside from the test I requested), so feel free to merge it once the test is added and Sander is satisfied.



================
Comment at: llvm/unittests/Analysis/InstructionCostTest.cpp:22
+
+TEST_F(CostTest, Operators) {
+  InstructionCost VThree = 3;
----------------
please add a test that a valid cost returns a value, and an invalid cost retruns a none.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91174/new/

https://reviews.llvm.org/D91174



More information about the llvm-commits mailing list