[PATCH] D89562: [flang]Add Parser Support for OpenMP Allocate Directive

[Irina Dobrescu via Phabricator via llvm-commits]

Rin added inline comments.


================
Comment at: flang/include/flang/Parser/parse-tree.h:3625
+  std::tuple<Verbatim, OmpObjectList, OmpClauseList> t;
+};
+
----------------
clementval wrote:
> Rin wrote:
> > Rin wrote:
> > > clementval wrote:
> > > > Is there a good reason to have separate nodes (`OpenMPDeclarativeAllocate`, `OpenMPExecutableAllocateList`)? Both node have the same content. 
> > > OpenMPDeclarativeAllocate is part of the Declarative construct, whereas OpenMPExecutableAllocateList is part of the Executable construct. I can't use OpenMPDeclarativeAllocate as an executable construct is expected.
> > I had the same idea to use the OpenMPDeclarativeAllocate, but failed to find a way to make it work unfortunately :/
> You should be able to use the same node in the two variants. What kind of problem did you face? 
My issue was that OpenMPDeclarativeAllocate is a Declarative construct and an Executable construct was expected. I could add OpenMPDeclarativeAllocate to the Executable construct variant and see if that works


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89562/new/

https://reviews.llvm.org/D89562