[PATCH] D91704: [llvm-mca] Fix processing thumb instruction set

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 07:16:31 PST 2020


andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/MCA/InstrBuilder.cpp:319-320
 
+    // if definition is Thumb1 optional def (s_cc_out) skip it and save
+    // optional def index for later processing.
+    if (MCDesc.OpInfo[CurrentDef].isOptionalDef()) {
----------------
This comment can be removed. It is no longer a Thumb1 thing only.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91704/new/

https://reviews.llvm.org/D91704



More information about the llvm-commits mailing list