[PATCH] D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS
Andrey Churbanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 24 06:44:51 PST 2020
AndreyChurbanov added inline comments.
Comment at: openmp/runtime/src/z_Linux_asm.S:1744
- .global __kmp_unnamed_critical_addr
+ .global KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr)
> I guess several architecture like KMP_ARCH_PPC64, KMP_ARCH_MIPS64, and KMP_ARCH_RISCV64 doesn't have KMP_PREFIX_UNDERSCORE definition here. I may be wrong, though. I'm working on VE architecture which is not merged yet. It shows compile error here after this patch.
I've submitted https://reviews.llvm.org/D92027 with attempt to fix your problem.
Could you please check if it works for you.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits