[PATCH] D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 24 05:53:45 PST 2020
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-notes.test:121
+# ERR1-GNU-NEXT: Owner Data size Description
+# ERR1-GNU-NEXT: warning: '[[FILE]]': unable to read notes from the SHT_NOTE section with index 1: SHT_NOTE section [index 1] has invalid offset (0xffff0000) or size (0x0)
+# ERR1-GNU-NOT: {{.}}
----------------
The mention of the "SHT_NOTE section [index 1]" happens twice redundantly. Same issue with the program header below. Do you think we could omit some of this redudant context?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92021/new/
https://reviews.llvm.org/D92021
More information about the llvm-commits
mailing list