[PATCH] D90304: [GlobalISel] Introduce global variant of regbankselect

[Gabriel Hjort Åkerlund via Phabricator via llvm-commits]

ehjogab marked an inline comment as done.
ehjogab added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:1178-1179
+      unsigned NumInserted = 0;
+      assignRegBank(MI, MIB, NumInserted);
+      MII = std::next(MII, NumInserted);
+    }
----------------
ehjogab wrote:
> arsenm wrote:
> > Is this intended to allow applyMappingImpl to insert new instructions which will iteratively have banks assigned? If so I think having a feature disparity with the single pass path is a problem
> Are you saying that I should rewrite the code to make use of applyMappingImpl, such that both single- and multi-pass make use of it? Because currently the multi-pass doesn't use it at all.
Feature disparity addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90304/new/

https://reviews.llvm.org/D90304