[PATCH] D91962: Add support for STRICT_FSETCC promotion

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

See the two inline comments about STRICT_FSETCCS.  I guess that shows this path is not really exercised right now -- maybe it would be a good idea to add some tests.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4421
+      Node->getOpcode() == ISD::STRICT_SINT_TO_FP ||
+      Node->getOpcode() == ISD::STRICT_FSETCC)
     OVT = Node->getOperand(1).getSimpleValueType();
----------------
I guess this needs to handle STRICT_FSETCCS here as well.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4632
+      SDVTList VTs = DAG.getVTList(Node->getValueType(0), MVT::Other);
+      Results.push_back(DAG.getNode(ISD::STRICT_FSETCC, dl, VTs,
+                                    {OutChain, Tmp1, Tmp2, Node->getOperand(3)},
----------------
Should use STRICT_FSETCCS here if we're expanding STRICT_FSETCCS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91962/new/

https://reviews.llvm.org/D91962