[PATCH] D91729: [PowerPC] dyn_cast should be dyn_cast_or_null in MASSV pass

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 03:30:12 PST 2020


steven.zhang accepted this revision.
steven.zhang added a comment.
This revision is now accepted and ready to land.

LGTM as I indeed see the crash fixed.



================
Comment at: llvm/test/CodeGen/PowerPC/powf_massv_075_025exp.ll:74
+  %wide.load = load <4 x float>, <4 x float>* %0, align 4
+  %1 = call ninf afn nsz <4 x float> @__powf4_massv(<4 x float> %wide.load, <4 x float> <float 0x3FE861EB80000000, float 0x3FE871EB80000000, float 0x3FE851EB80000000, float 0x3FE851EB80000000>)
+  %2 = bitcast float* %next.gep to <4 x float>*
----------------
masoud.ataei wrote:
> Four slots of the second vector float in __powf4_massv arguments has non-equal constants.
Usually, we will add some comments in the test to indicate that no crash any more. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91729/new/

https://reviews.llvm.org/D91729



More information about the llvm-commits mailing list