[PATCH] D91849: [WebAssembly] Factor out WasmTableType in binary format

Tue Nov 24 01:54:12 PST 2020

wingo added a comment.

I guess I should ask for commit rights so I can land after approval; would you be OK sponsoring my request, Sam?  In the meantime if you would like to land this one that would be grand :)

================
Comment at: llvm/tools/obj2yaml/wasm2yaml.cpp:237
+          // FIXME: Currently we always output an index of 0 for any imported
+          // table.
+          Im.TableImport = makeTable(0, Import.Table);
----------------
sbc100 wrote:
> Hmm.. is this true for GlobalImport and EventImport too?   It looks like none of them set `Index`.
> 
> It it worth switching `Im.TableImport` to be of type `TypeType` instead of `Table?    Maybe that comes latest when the FIXME is addressed?
Yeah this is true of GlobalImport and EventImport also.  Agreed that it does make sense here to just store a `TableType`; can fix in a followup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91849/new/

https://reviews.llvm.org/D91849