[PATCH] D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a subscriber: tskeith.
kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:1213-1217
+  // Identify all the namelist objects
+  GetNamelistSymbols(namelistSymbols, currScope().parent());
+  if (ultimateScope.IsModule()) {
+    GetNamelistSymbols(namelistSymbols, ultimateScope);
+  }
----------------
Calling GetNamelistSymbols for finding all the namelist objects each time CheckObjectInNameList (for each variable in the private list) is called seems to be not optimal.

@tskeith Is there a better way to check whether a variable is part of a namelist?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90210/new/

https://reviews.llvm.org/D90210