[PATCH] D91964: [llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog`

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test:77
+
+## Check that llvm-readelf reports a warning when we unable to read the name of
+## the section linked with the SHT_GNU_verdef section (usually ".dynstr").
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/verneed-invalid.test:403
+
+## Check that llvm-readelf reports a warning when we unable to read the name of
+## the section linked with the SHT_GNU_verneed section (usually ".dynstr").
----------------



================
Comment at: llvm/test/tools/llvm-readobj/ELF/versym-invalid.test:81-82
 
-# MISALIGNED-GNU:      Version symbols section '.gnu.version' contains 0 entries:
-# MISALIGNED-GNU-NEXT:  Addr: 0000000000000000  Offset: 0x00ffff  Link: 0 ()
 # MISALIGNED-GNU-NEXT:  warning: '[[FILE]]': the SHT_GNU_versym section with index 1 is misaligned
----------------
This provided incidental coverage of the section having sh_link 0 and therefore that the target section was empty. Is this covered elsewhere/worth continuing to cover (with a dedicated test case)?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/versym-invalid.test:126
+
+## Check that llvm-readelf reports a warning when we unable to read the name of
+## the section linked with the SHT_GNU_verneed section (usually ".dynsym").
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91964/new/

https://reviews.llvm.org/D91964