[PATCH] D91704: [llvm-mca] Fix processing thumb instruction set

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 00:29:38 PST 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10312
       MCInst TmpInst;
-      TmpInst.setOpcode(Inst.getOperand(4).getReg() ? ARM::tMOVSr : ARM::tMOVr);
+      unsigned Op = Inst.getOperand(4).getReg() ? ARM::tMOVSr : ARM::tMOVr;
+      TmpInst.setOpcode(Op);
----------------
Do you mind pulling this out into it's own review. I think it's fine, but just in case it probably deserves to be it's own patch.

The test can stay here, so long as there is some test for `movs rm, rn`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91704/new/

https://reviews.llvm.org/D91704



More information about the llvm-commits mailing list