[PATCH] D92003: Modify the comment of ErrorHandlerTraits in Error.h
Wang Yihan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 21:43:50 PST 2020
yihanaa created this revision.
Herald added subscribers: llvm-commits, dexonsmith.
Herald added a project: LLVM.
yihanaa requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D92003
Files:
llvm/include/llvm/Support/Error.h
Index: llvm/include/llvm/Support/Error.h
===================================================================
--- llvm/include/llvm/Support/Error.h
+++ llvm/include/llvm/Support/Error.h
@@ -788,7 +788,7 @@
: public ErrorHandlerTraits<decltype(
&std::remove_reference<HandlerT>::type::operator())> {};
-// Specialization functions of the form 'Error (const ErrT&)'.
+// Specialization functions of the form 'Error (ErrT&)'.
template <typename ErrT> class ErrorHandlerTraits<Error (&)(ErrT &)> {
public:
static bool appliesTo(const ErrorInfoBase &E) {
@@ -802,7 +802,7 @@
}
};
-// Specialization functions of the form 'void (const ErrT&)'.
+// Specialization functions of the form 'void (ErrT&)'.
template <typename ErrT> class ErrorHandlerTraits<void (&)(ErrT &)> {
public:
static bool appliesTo(const ErrorInfoBase &E) {
@@ -850,12 +850,12 @@
}
};
-// Specialization for member functions of the form 'RetT (const ErrT&)'.
+// Specialization for member functions of the form 'RetT (ErrT&)'.
template <typename C, typename RetT, typename ErrT>
class ErrorHandlerTraits<RetT (C::*)(ErrT &)>
: public ErrorHandlerTraits<RetT (&)(ErrT &)> {};
-// Specialization for member functions of the form 'RetT (const ErrT&) const'.
+// Specialization for member functions of the form 'RetT (ErrT&) const'.
template <typename C, typename RetT, typename ErrT>
class ErrorHandlerTraits<RetT (C::*)(ErrT &) const>
: public ErrorHandlerTraits<RetT (&)(ErrT &)> {};
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92003.307243.patch
Type: text/x-patch
Size: 1501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201124/dfb572af/attachment.bin>
More information about the llvm-commits
mailing list