[PATCH] D91999: [hwasan] Fix tests when vm.overcommit_memory=1.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 16:05:57 PST 2020

eugenis created this revision.
eugenis added reviewers: pcc, hctim.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.
eugenis requested review of this revision.

Remove an invalid check from sizes.cpp that only passes when overcommit is disabled.

Fixes PR48274.

  rG LLVM Github Monorepo



Index: compiler-rt/test/hwasan/TestCases/sizes.cpp
--- compiler-rt/test/hwasan/TestCases/sizes.cpp
+++ compiler-rt/test/hwasan/TestCases/sizes.cpp
@@ -49,8 +49,6 @@
   if (!untag_strcmp(argv[1], "malloc")) {
     void *p = malloc(MallocSize);
-    p = malloc(kMaxAllowedMallocSize - kChunkHeaderSize);
-    assert(!p);
   } else if (!untag_strcmp(argv[1], "calloc")) {
     // Trigger an overflow in calloc.
     size_t size = std::numeric_limits<size_t>::max();

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91999.307210.patch
Type: text/x-patch
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201124/0a56860a/attachment.bin>

More information about the llvm-commits mailing list