[PATCH] D91734: [FastISel] Flush local value map on every instruction
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 14:56:28 PST 2020
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I think the code looks good, but I don't want to create an orphaned test case for emergency spill slot creation. Please file a bug about it, reference it from the comments, and go ahead and land it.
I filed a bug about the hwasan test failure, and Evgeniy is looking into it:
Comment at: llvm/test/CodeGen/Mips/emergency-spill-slot-near-fp.ll:5-6
+; After recent rework to FastISel, don't know how to trigger the emergency
+; spill slot.
+; XFAIL: *
> Huh. @MatzeB, do you think this test case can be repaired?
Given that Matthias hasn't responded, please file a bug about this, assign it to him, reference it here, and we'll commit it like that.
CHANGES SINCE LAST ACTION
More information about the llvm-commits