[PATCH] D91481: [LoopUnroll] Discount uniform instructions in cost models

Mon Nov 23 13:24:38 PST 2020

fhahn added a comment.

In D91481#2411958 <https://reviews.llvm.org/D91481#2411958>, @reames wrote:

> In D91481#2410666 <https://reviews.llvm.org/D91481#2410666>, @samparker wrote:
>
>> This looks sensible to me and a step in the right direction. Have you ran any benchmarks? Would be good to know, at least, that this isn't causing any obvious regressions.
>
> I haven't.  I'm not particularly setup to do so easily either.

It might be helpful to build llvm-test-suite and check the impact on the number of unrolled loops using statistics (-DTEST_SUITE_COLLECT_STATS)? That should give a rough idea on how broad the impact is going to be, without having actual HW for benchmarking.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91481/new/

https://reviews.llvm.org/D91481