[PATCH] D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS
Andrey Churbanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 23 13:17:39 PST 2020
AndreyChurbanov requested changes to this revision.
AndreyChurbanov added a comment.
This revision now requires changes to proceed.
I am sorry, my accept action was not formal enough.
What you can do now is:
1. clone the monorepo;
2. apply your changes to openmp/runtime/src/z_Linux_asm.S, please also address @arichardson's comment on #if/#ifdef;
3. run diff, e.g: $ git diff -U 999999 > newdiff.diff
4. update the review diff with newdiff.diff (of cause, feel free to chose whatever name you like for the file instead of newdiff).
Once the updated patch is approved, it needs to be landed. Do you have commit permission to the monorepo?
If not, you can ask somebody who has the permission to commit the patch for you (e.g. I can do this).
CHANGES SINCE LAST ACTION
More information about the llvm-commits