[PATCH] D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

This seems fine, but the patch should be uploaded against the monorepo so that it shows up as openmp/runtime/src/z_Linux_asm.S.



================
Comment at: z_Linux_asm_ifelf.S:1752
     .8byte .gomp_critical_user_
-    .size __kmp_unnamed_critical_addr,8
+#if __ELF__
+    .size KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr),8
----------------
This shoud be `#ifdef`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88252/new/

https://reviews.llvm.org/D88252