[PATCH] D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null

[Eric Astor via Phabricator via llvm-commits]

epastor added inline comments.


================
Comment at: llvm/tools/llvm-ml/llvm-ml.cpp:77
 public:
-  MLOptTable() : OptTable(InfoTable, true) {}
+  MLOptTable() : OptTable(InfoTable, /*IgnoreCase=*/false) {}
 };
----------------
thakis wrote:
> mention this change in cl description, add test for it
> 
> ....but I don't think this change is correct?
> 
> ```
> C:\src>ml64 foo.asm /c /foasdf.obj /nologo
> Microsoft (R) Macro Assembler (x64) Version 14.25.28614.0
> Copyright (C) Microsoft Corporation.  All rights reserved.
> 
>  Assembling: foo.asm
> MASM : warning A4018:invalid command-line option : /foasdf.obj
> ```
This is correcting us to match ml64; we previously considered /fo equivalent to /Fo, but this was a mistake. However, I'll push it up the stack to the change that introduced the problem instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90061/new/

https://reviews.llvm.org/D90061